Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interface class for iris Cube datasets #624

Merged
merged 4 commits into from
Apr 20, 2016
Merged

Conversation

philippjfr
Copy link
Member

This PR adds an interface for iris Cube datasets to work with large out-of-memory datasets. The interface isn't entirely complete but supports all the basic functionality to work with such a dataset.

In future we can think about also implementing the sample and aggregate methods but it should not hold up this PR.

@@ -15,13 +15,23 @@
from .grid import GridInterface
from .ndelement import NdElementInterface

datatypes = ['array', 'dictionary', 'grid', 'ndelement']

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because you are considering setting datatypes with hv.core.data.datatypes = [ 'dictionary'] for example? Makes sense, for convenience but I would like to know if there was any another reason for moving it off the class itself.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I can populate it depending on the availability of the various data backends. Happy to change the way this is handled though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is perfectly fine - just seems more flexible this way.

@philippjfr philippjfr force-pushed the iris_interface branch 2 times, most recently from 8293694 to 84cb085 Compare April 20, 2016 09:24
from holoviews.element.comparison import ComparisonTestCase

class TestCube(ComparisonTestCase):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Maybe we can get some people who are familiar with Iris tests to add some more of their own. :-)

@jlstevens
Copy link
Contributor

Looks good! Happy to merge once the tests pass and you are happy with the number of tests for the time being.

@philippjfr
Copy link
Member Author

Ready to merge, I think the push build is getting confused about the updated data, but the PR build passed.

@jlstevens
Copy link
Contributor

The pr build is the one that counts. Merging.

@jlstevens jlstevens merged commit 99bb3ad into master Apr 20, 2016
@philippjfr philippjfr deleted the iris_interface branch April 20, 2016 23:20
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants